Fixes #24056 Dealias value class types in structural access#25907
Open
soronpo wants to merge 1 commit intoscala:mainfrom
Open
Fixes #24056 Dealias value class types in structural access#25907soronpo wants to merge 1 commit intoscala:mainfrom
soronpo wants to merge 1 commit intoscala:mainfrom
Conversation
When a structural refinement member has a type that is a type alias for a generic derived value class, the boxing wrapper in `maybeBoxingCast` synthesized a `New` on the alias, which provided only the alias' partial type arguments to the underlying class constructor and failed with "Not enough type arguments". Dealias the widened type before constructing the `New` so the underlying value class receives its full type argument list. Fixes scala#24056
soronpo
force-pushed
the
fix-i24056-value-class-alias-structural
branch
from
43f748b to
cb5bf4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a structural refinement member has a type that is a type alias for a generic derived value class, the boxing wrapper in
maybeBoxingCastsynthesized aNewon the alias, which provided only the alias' partial type arguments to the underlying class constructor and failed with "Not enough type arguments".Dealias the widened type before constructing the
Newso the underlying value class receives its full type argument list.Fixes #24056
How much have you relied on LLM-based tools in this contribution?
Extensively, but this is a single line change.
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)