Skip to content

Fix stable reference check for And types with type params#25940

Open
HarrisL2 wants to merge 1 commit intoscala:mainfrom
HarrisL2:type-param-stable-and
Open

Fix stable reference check for And types with type params#25940
HarrisL2 wants to merge 1 commit intoscala:mainfrom
HarrisL2:type-param-stable-and

Conversation

@HarrisL2
Copy link
Copy Markdown
Contributor

Fixes existing bug that also resurfaced in open community build with explicit-nulls enabled in the following project
neandertech/langoustine

How much have you relied on LLM-based tools in this contribution?

Extensively, for producing the appropriate fix

How was the solution tested?

New automated tests at
tests/explicit-nulls/pos/opt.scala
and a previously disabled test at
tests/explicit-nulls/pos/flow-stable.scala

@noti0na1
Copy link
Copy Markdown
Member

I remember a long time (at least 5yr) ago @sjrd remind me something about stable checking on andtypes is not trival.

@HarrisL2
Copy link
Copy Markdown
Contributor Author

I see, this was mostly an LLM generated fix and I'm not familiar with the nuance of this section of code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants