Fix stable reference check for And types with type params#25940
Open
HarrisL2 wants to merge 1 commit intoscala:mainfrom
Open
Fix stable reference check for And types with type params#25940HarrisL2 wants to merge 1 commit intoscala:mainfrom
HarrisL2 wants to merge 1 commit intoscala:mainfrom
Conversation
Member
|
I remember a long time (at least 5yr) ago @sjrd remind me something about stable checking on andtypes is not trival. |
Contributor
Author
|
I see, this was mostly an LLM generated fix and I'm not familiar with the nuance of this section of code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes existing bug that also resurfaced in open community build with explicit-nulls enabled in the following project
neandertech/langoustine
How much have you relied on LLM-based tools in this contribution?
Extensively, for producing the appropriate fix
How was the solution tested?
New automated tests at
tests/explicit-nulls/pos/opt.scala
and a previously disabled test at
tests/explicit-nulls/pos/flow-stable.scala