Stop capturing a Context for optimizer warnings#26236
Open
SolalPirelli wants to merge 9 commits into
Open
Conversation
SolalPirelli
force-pushed
the
solal/optwarning
branch
from
f792371 to
a757c94
Compare
SolalPirelli
force-pushed
the
solal/optwarning
branch
from
5284672 to
3181cb1
Compare
SolalPirelli
commented
Jun 11, 2026
| sub-cases-reachability.scala | ||
| tailrec.scala | ||
| traitParams.scala | ||
| optimizer-warnings.scala |
Contributor
Author
There was a problem hiding this comment.
the positions are wrong when SCoverage is on, I'll create an issue to investigate further, but for now I think "coverage + optimizer" isn't really a meaningful scenario anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #26174Part of #25218
Review commit by commit
Removes the last thing that captured a Context.
This PR:
How much have you relied on LLM-based tools in this contribution?
Not at all
How was the solution tested?
Covered by existing tests (this is a refactoring)