fix: #25843 Strip capture annotations when analyzing match type cases#26306
Open
halotukozak wants to merge 1 commit into
Open
fix: #25843 Strip capture annotations when analyzing match type cases#26306halotukozak wants to merge 1 commit into
halotukozak wants to merge 1 commit into
Conversation
…a#25843) During capture checking, a match type case can be wrapped in capture annotations, e.g. `AnnotatedType(MatchCase(...), CaptureAnnotation)`. `MatchTypeCaseSpec.analyze` did not account for this: the annotated case matched neither the `HKTypeLambda` cases nor `defn.MatchCase`, so the `@unchecked` destructuring threw a MatchError and crashed the compiler during the CheckCaptures phase. Strip the annotations before destructuring: recurse through AnnotatedType to the underlying case, and dealias annotations off the result type in the HKTypeLambda case. For non-annotated match types this is a no-op. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25843
How much have you relied on LLM-based tools in this contribution?
Extensively, for finding the root cause. Self-reviewed before the PR.
How was the solution tested?
New automated test
i25843.scalaadded