Upgrade to tensorstore 0.1.72 and drop Python 3.9 #1277
Conversation
| @@ -30,7 +30,7 @@ classifiers = [ | |||
| "Programming Language :: Python :: 3.13", | |||
| ] | |||
|
|
|||
| requires-python = ">=3.9,<3.14" | |||
| requires-python = ">=3.10,<3.14" | |||
There was a problem hiding this comment.
Please also remove "Programming Language :: Python :: 3.9" in line 26
There was a problem hiding this comment.
Line 150-151 should be updated too.
|
Looks good to me. Do we want to keep the python 3.9 support for cluster_tools? Otherwise we should update the pyproject.toml file there too. |
|
I updated mypy and ruff and applied the changes. I realize this makes this PR unreviewable. Maybe you can have a look at just https://github.com/scalableminds/webknossos-libs/pull/1277/files/87f7a34e5bfc970ea51fdad8bc56509b809396be..4639d0ab881e15222afb16f9128483ecb644cf47 |
| @@ -399,7 +398,7 @@ def download( | |||
| *, | |||
| skip_volume_data: bool = False, | |||
| _return_context: bool = False, | |||
| ) -> Union["Annotation", tuple["Annotation", ContextManager[None]]]: | |||
| ) -> Union["Annotation", tuple["Annotation", AbstractContextManager[None]]]: | |||
There was a problem hiding this comment.
Why is the Union[] notation not replaced here?
There was a problem hiding this comment.
Ruff was too afraid to change the types with "strings" in it. I went through and changed them manually.
There was a problem hiding this comment.
Seems to be problematic to use strings for the | operator. For python 3.11 and above, we could use type Self. https://stackoverflow.com/questions/33533148/how-do-i-type-hint-a-method-with-the-type-of-the-enclosing-class
There was a problem hiding this comment.
Yeah. I reverted that. Ruff kept them for a good reason 😅
Description:
Todos:
Make sure to delete unnecessary points or to check all before merging: