Skip to content

Conversation

brokkoli71
Copy link
Contributor

@brokkoli71 brokkoli71 commented Jul 22, 2025

Description:

  • Volume Annotations can be created and modified

Further Changes:

  • The volume layer data of downloaded annotations must be stored in a directory. This could be circumvented, but it would require further changes.

Issues:

Todos:

  • How to test uploading volume annotation to wk?
  • Memory Store
  • is the created volume annotation zip correct?
  • fix slow tests

Todos Documentation:

  • Updated Changelog
  • Updated Documentation
  • Added / Updated Tests

@brokkoli71 brokkoli71 self-assigned this Aug 9, 2025
f"Unsupported volume layer edit mode: {volume_layer_edit_mode}"
)

def export_to_dataset(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeLayer.export_to_dataset is extracted from Annotation.export_volume_layer_to_dataset

# Conflicts:
#	webknossos/tests/cassettes/test_annotation/test_annotation_upload_download_roundtrip.yml
#	webknossos/tests/cassettes/test_annotation/test_bounding_box_roundtrip.yml
@brokkoli71 brokkoli71 marked this pull request as ready for review August 29, 2025 11:22
Copy link

github-actions bot commented Aug 31, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
9456 7943 84% 80% 🟢

New Files

File Coverage Status
webknossos/webknossos/annotation/volume_layer.py 98% 🟢
TOTAL 98% 🟢

Modified Files

File Coverage Status
webknossos/webknossos/annotation/annotation.py 79% 🟢
webknossos/webknossos/client/api_client/wk_api_client.py 89% 🟢
webknossos/webknossos/dataset/view.py 89% 🟢
TOTAL 86% 🟢

updated for commit: aa66ed8 by action🐍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one could be rewritten to actually use the new create-annotation feature.

brokkoli71 and others added 7 commits September 5, 2025 11:22
# Conflicts:
#	webknossos/tests/cassettes/test_annotation/test_annotation_upload_download_roundtrip.yml
#	webknossos/tests/cassettes/test_annotation/test_bounding_box_roundtrip.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create volume annotations
3 participants