Skip to content

Conversation

valentin-pinkau
Copy link
Member

@valentin-pinkau valentin-pinkau commented Aug 27, 2025

Description:

  • This PR adds get_agglomerate_graph the Annotation class.

Todos:

Make sure to delete unnecessary points or to check all before merging:

  • Updated Changelog
  • Added / Updated Tests

@valentin-pinkau valentin-pinkau self-assigned this Aug 27, 2025
Copy link

github-actions bot commented Sep 3, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
10251 8413 82% 80% 🟢

New Files

File Coverage Status
webknossos/webknossos/proofreading/_init_.py 100% 🟢
webknossos/webknossos/proofreading/agglomerate_graph.py 55% 🟢
webknossos/webknossos/proofreading/generated/_init_.py 100% 🟢
webknossos/webknossos/proofreading/generated/agglomerate_graph_pb2.py 28% 🟢
TOTAL 71% 🟢

Modified Files

File Coverage Status
webknossos/webknossos/annotation/annotation.py 78% 🟢
webknossos/webknossos/client/api_client/_abstract_api_client.py 90% 🟢
webknossos/webknossos/client/api_client/models.py 100% 🟢
webknossos/webknossos/client/api_client/tracingstore_api_client.py 52% 🟢
TOTAL 80% 🟢

updated for commit: 16a7232 by action🐍

@valentin-pinkau valentin-pinkau requested a review from fm3 September 3, 2025 11:55
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet stuff!

@valentin-pinkau valentin-pinkau requested a review from fm3 October 14, 2025 11:42
@valentin-pinkau
Copy link
Member Author

@fm3 Please have another look :)

Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :) Added some more comments/questions. Also please add a changelog.

Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@valentin-pinkau valentin-pinkau merged commit 4712a0a into master Oct 15, 2025
23 checks passed
@valentin-pinkau valentin-pinkau deleted the get_agglomerate_graph branch October 15, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants