-
Notifications
You must be signed in to change notification settings - Fork 27
Add automatic dev deployment on push #7657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
could we have this maybe only if the PR is ready for review? |
Done now. As discussed after the presentation, it is not exactly clear how to proceed here. i.e. require a label, what should be the default, is draft status relevant? |
I like the idea of a |
Yes, it is possible to run a GitHub action on a label change (https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request). However, this would then be a GitHub action and not a circleCI action. Another question would be when this should run:
|
Maybe it would be best to just check at the end of every CircleCI run whether the label is present and deploy/update accordingly. Removing deployments would still be manual. |
Would it make things easier to use the |
e9152e6
to
7f2603a
Compare
7f2603a
to
c23f1a9
Compare
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Waiting for #8147 |
With Github CI now used, this should be simpler to do. Closing this PR for now, since this one dealt with circle CI, we can also create a new one. |
Currently working on editing this comment, but the Github Token does not alow for that.
https://___.webknossos.xyz
(Please delete unneeded items, merge only when none are left open)