Skip to content

Commit

Permalink
Update scalafmt settings. prepare Scala 3.4
Browse files Browse the repository at this point in the history
  • Loading branch information
xuwei-k committed Dec 24, 2023
1 parent 5450859 commit 04c5ad6
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 7 deletions.
9 changes: 9 additions & 0 deletions .scalafmt.conf
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,12 @@ optIn.breakChainOnFirstMethodDot = false
trailingCommas = preserve
version = "3.7.17"
project.layout = StandardConvention
rewrite.scala3.convertToNewSyntax = true
fileOverride {
"glob:**/src/**/scala-3/**" {
rewrite.scala3.convertToNewSyntax = false
}
}
runner.dialectOverride.allowSignificantIndentation = false
runner.dialectOverride.allowAsForImportRename = false
runner.dialectOverride.allowStarWildcardImport = false
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import JsonFormatSpecBase.assertThrows
trait JavaAssertionsPlatform {
self: TestSuite with JavaAssertions =>

def registeredCompanions: Seq[GeneratedMessageCompanion[_]]
def registeredCompanions: Seq[GeneratedMessageCompanion[?]]

val JavaJsonTypeRegistry =
this.registeredCompanions
Expand Down
10 changes: 5 additions & 5 deletions core/shared/src/main/scala/scalapb_argonaut/JsonFormat.scala
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import scala.util.control.NonFatal
case class Formatter[T](writer: (Printer, T) => Json, parser: (Parser, Json) => T)

case class FormatRegistry(
messageFormatters: Map[Class[_], Formatter[_]] = Map.empty,
messageFormatters: Map[Class[?], Formatter[?]] = Map.empty,
enumFormatters: Map[EnumDescriptor, EnumFormatter[EnumValueDescriptor]] = Map.empty,
registeredCompanions: Seq[GenericCompanion] = Seq.empty
) {
Expand All @@ -45,11 +45,11 @@ case class FormatRegistry(
registerMessageFormatter((p: Printer, t: T) => writer(t), (p: Parser, v: Json) => parser(v))
}

def getMessageWriter[T](klass: Class[_ <: T]): Option[(Printer, T) => Json] = {
def getMessageWriter[T](klass: Class[? <: T]): Option[(Printer, T) => Json] = {
messageFormatters.get(klass).asInstanceOf[Option[Formatter[T]]].map(_.writer)
}

def getMessageParser[T](klass: Class[_ <: T]): Option[(Parser, Json) => T] = {
def getMessageParser[T](klass: Class[? <: T]): Option[(Parser, Json) => T] = {
messageFormatters.get(klass).asInstanceOf[Option[Formatter[T]]].map(_.parser)
}

Expand Down Expand Up @@ -371,7 +371,7 @@ class Parser private (config: Parser.ParserConfig) {
}

private def fromJsonToPMessage(
cmp: GeneratedMessageCompanion[_],
cmp: GeneratedMessageCompanion[?],
value: Json,
skipTypeUrl: Boolean
): PMessage = {
Expand Down Expand Up @@ -502,7 +502,7 @@ class Parser private (config: Parser.ParserConfig) {
}

protected def parseSingleValue(
containerCompanion: GeneratedMessageCompanion[_],
containerCompanion: GeneratedMessageCompanion[?],
fd: FieldDescriptor,
value: Json
): PValue =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import scalapb_json._

trait JavaAssertions extends JavaAssertionsPlatform { self: utest.TestSuite =>

def registeredCompanions: Seq[GeneratedMessageCompanion[_]] = Seq.empty
def registeredCompanions: Seq[GeneratedMessageCompanion[?]] = Seq.empty

val ScalaTypeRegistry = registeredCompanions.foldLeft(TypeRegistry.empty)((r, c) =>
r.addMessageByCompanion(c.asInstanceOf[GenericCompanion])
Expand Down

0 comments on commit 04c5ad6

Please sign in to comment.