Skip to content

Fix getting a free socket on macos #420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thesamet merged 2 commits into from
May 12, 2025
Merged

Fix getting a free socket on macos #420

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae484c8
fix getting a free socket on macos
reimai Mar 25, 2025
80be654
free socket for windows; fmt
reimai Apr 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions bridge/src/main/scala/protocbridge/frontend/SocketBasedPluginFrontend.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,27 @@ package protocbridge.frontend

import protocbridge.{ExtraEnv, ProtocCodeGenerator}

import java.net.ServerSocket
import java.net.{InetAddress, ServerSocket}
import java.nio.file.{Files, Path}
import scala.concurrent.ExecutionContext.Implicits.global
import scala.concurrent.{Future, blocking}

/** PluginFrontend for Windows and macOS where a server socket is used.
*/
abstract class SocketBasedPluginFrontend extends PluginFrontend {

case class InternalState(serverSocket: ServerSocket, shellScript: Path)

override def prepare(
plugin: ProtocCodeGenerator,
env: ExtraEnv
): (Path, InternalState) = {
val ss = new ServerSocket(0) // Bind to any available port.

/** we need to specify an address, otherwise it uses ANY (*.* in netstat)
* which does not conflict with existing 'localhost' sockets on macos,
* resulting in a conflict later on in MacPluginFrontend
*/
val ss = new ServerSocket(0, 50, InetAddress.getByName("127.0.0.1"))
val sh = createShellScript(ss.getLocalPort)

Future {
Expand Down
Loading