Skip to content
This repository was archived by the owner on Aug 28, 2024. It is now read-only.

feat: unify snippetz and httpsnippet-lite#47

Closed
tmastrom wants to merge 2 commits intomainfrom
tom/doc-2207-unify-snippetz
Closed

feat: unify snippetz and httpsnippet-lite#47
tmastrom wants to merge 2 commits intomainfrom
tom/doc-2207-unify-snippetz

Conversation

@tmastrom
Copy link

@tmastrom tmastrom commented Aug 14, 2024

This PR wraps and exports types and methods from httpsnippet-lite and unifies the @scalar/snippetz print method.

Existing code is executed when printing js | node and we try to use the convert method from httpsnippet-lite for other cases.

Todo

  • wrangle the types
    - httpsnippet-lite docs want a full client type object to be passed to convert although their docs say you can pass an id??
  • playground example

@tmastrom tmastrom requested a review from geoffgscott August 14, 2024 00:48
@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2024

⚠️ No Changeset found

Latest commit: 82742c1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for scalar-snippetz failed. Why did it fail? →

Name Link
🔨 Latest commit 82742c1
🔍 Latest deploy log https://app.netlify.com/sites/scalar-snippetz/deploys/66bbfefb88c7930008e88dec

@tmastrom
Copy link
Author

migrating to scalar monorepo

@tmastrom tmastrom closed this Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant