Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Video Cropping #54

Closed
CryogenicPlanet opened this issue Jul 31, 2020 · 3 comments · Fixed by #93
Closed

Video Cropping #54

CryogenicPlanet opened this issue Jul 31, 2020 · 3 comments · Fixed by #93
Assignees
@CryogenicPlanet
Labels
bug Something isn't working

Comments

@CryogenicPlanet
Copy link
Member

Beta Domain: https://beta.videotranscode.space/

Settings transcode h.264 mp4

Cropped video the 16:9

Original Video File: https://drive.google.com/file/d/1FN6oXgJcLBIGEM6rzJasIpg0SLfCFcJT/view?usp=sharing
@CryogenicPlanet CryogenicPlanet added the bug Something isn't working label Jul 31, 2020
@CryogenicPlanet
Copy link
Member Author

Suspected that the cropping is only in the video displayer not the download itself, @rithvikmahin can you fix this

image

@CryogenicPlanet CryogenicPlanet removed their assignment Jul 31, 2020
@CryogenicPlanet
Copy link
Member Author

@rithvikmahin https://css-tricks.com/aspect-ratio-boxes/

CryogenicPlanet added a commit that referenced this issue Aug 6, 2020
@CryogenicPlanet
📺 Temporary Fix to #54
4a25239
@CryogenicPlanet
Copy link
Member Author

#4a25239 Commit has created a temporary solution by allowing the DOM object to respond to aspect ratio of the inputted video

This is not a good solution as the video file itself is not properly fitted into the video tag but rather the entire container is resized, this also does not work in fullscreen mode.

This is the state variable that controls this solution
https://github.com/Etwas-Builders/Video-Transcoder/blob/4a252394299b637f0497e75f0070b3376cf05527/src/components/video/video.tsx#L312

@CryogenicPlanet CryogenicPlanet mentioned this issue Aug 6, 2020
Closed
CryogenicPlanet added a commit that referenced this issue Aug 11, 2020
@CryogenicPlanet
📺 Temporary Fix to #54
7180101
CryogenicPlanet added a commit that referenced this issue Aug 14, 2020
@CryogenicPlanet
📺 Temporary Fix to #54
8cf742a
@CryogenicPlanet CryogenicPlanet mentioned this issue Sep 19, 2020
Open
CryogenicPlanet added a commit that referenced this issue Oct 27, 2020
@CryogenicPlanet
✨ New video player
9adc70f 
- Fixes Video Component Broken #56 and Fixes Video Cropping #54
@CryogenicPlanet CryogenicPlanet mentioned this issue Oct 27, 2020
Merged
CryogenicPlanet added a commit that referenced this issue Oct 27, 2020
@CryogenicPlanet
✨ New video player
f84be5e 
- Fixes Video Component Broken #56 and Fixes Video Cropping #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CryogenicPlanet CryogenicPlanet

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

✨ Adding gif support scalarhq/videotranscode.space
2 participants
@CryogenicPlanet @rithvikmahin