-
-
Notifications
You must be signed in to change notification settings - Fork 8
bug_26/dev2 #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
bug_26/dev2 #33
Conversation
ignore metals & bloop
add a test and an example for it
EngineExecutionListenerReporter now responds to TestStarting event differently depending on if it is a nested test case
… to use suiteId clean up imports
@tribbloid Sorry for the late response, the changes looks good to me, requires @bvenners 's approval and hopefully we can include this in 3.3.0.0. |
thanks a lot! Hope you don't mind it depending on ScalaFmt (can save a lot of merge conflict) this is actually not the minimal version, the minimal version (https://github.com/acyclicai/scalatestplus-junit5/blob/42cbf8a678660435d30d74177d353980c0824c67/src/main/scala/org/scalatestplus/junit5/EngineExecutionListenerReporter.scala) has I would suggest cherrypicking/PR from that instead |
@tribbloid Er, would you mind to create a new PR with that instead? I'll be working on staging 3.3.0.0 today so hopefully we can get it in if possible. |
no problem! submitting bug_26/dev5 shortly it is a fairly big PR but guarded by added tests |
include a fix for #26
current branch also contains formatting, version upgrade and maintenance improvements, they can be skipped / transferred to other PRs