Skip to content

bug_26/dev2 #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

bug_26/dev2 #33

wants to merge 9 commits into from

Conversation

tribbloid
Copy link

include a fix for #26

current branch also contains formatting, version upgrade and maintenance improvements, they can be skipped / transferred to other PRs

tribbloid added 9 commits July 3, 2025 14:06
ignore metals & bloop
add a test and an example for it
EngineExecutionListenerReporter now responds to TestStarting event differently depending on if it is a nested test case
@tribbloid
Copy link
Author

How can I revise it and push into the main branch?

image

@cheeseng
Copy link
Contributor

@tribbloid Sorry for the late response, the changes looks good to me, requires @bvenners 's approval and hopefully we can include this in 3.3.0.0.

@cheeseng cheeseng requested a review from bvenners August 14, 2025 14:13
@tribbloid
Copy link
Author

thanks a lot! Hope you don't mind it depending on ScalaFmt (can save a lot of merge conflict)

this is actually not the minimal version, the minimal version (https://github.com/acyclicai/scalatestplus-junit5/blob/42cbf8a678660435d30d74177d353980c0824c67/src/main/scala/org/scalatestplus/junit5/EngineExecutionListenerReporter.scala) has getQualifiedName and getQualifiedName fused together. It also has an integration test group that compares JUnit runner & scalaTest runner.

I would suggest cherrypicking/PR from that instead

@cheeseng
Copy link
Contributor

@tribbloid Er, would you mind to create a new PR with that instead? I'll be working on staging 3.3.0.0 today so hopefully we can get it in if possible.

@tribbloid
Copy link
Author

no problem! submitting bug_26/dev5 shortly

it is a fairly big PR but guarded by added tests

@tribbloid tribbloid mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants