Add support for vsphere on robotest #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anudeep-Gudipati
force-pushed
the
ag-support-vsphere-on-robotest
branch
from
22af6fe to
c8b0cc1
Compare
Anudeep-Gudipati
force-pushed
the
ag-support-vsphere-on-robotest
branch
from
c8b0cc1 to
559a712
Compare
yashaswaj
approved these changes
Jan 10, 2025
| # | ||
|
|
||
| resource "vsphere_virtual_machine" "node" { | ||
| #TODO: Move to vars!! |
|
|
||
| resource_pool_id = data.vsphere_compute_cluster.cluster.resource_pool_id | ||
|
|
||
| num_cpus = 4 |
There was a problem hiding this comment.
Why 4? Is there some component which requires this many minimum cpus?
| disk { | ||
| label = "disk0" | ||
| size = 64 | ||
| thin_provisioned = false #TODO(ag): Update the template to true and change here |
There was a problem hiding this comment.
nit: jira please. which template?
| } | ||
| } | ||
|
|
||
| #variable "os" { |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
| FROM quay.io/gravitational/debian-venti:go1.16.6-buster | ||
| FROM quay.io/gravitational/debian-venti:go1.17.5-stretch |
There was a problem hiding this comment.
Should we change the repo right now itself? We have put those in our gcr right?
| COPY entrypoint.sh /entrypoint.sh | ||
| COPY build/robotest-e2e /usr/bin/robotest-e2e | ||
| COPY polaris.pub /robotest/polaris.pub | ||
| COPY polaris.pem /robotest/polaris.pem |
There was a problem hiding this comment.
Is the path of polaris.pem and pub right?
There was a problem hiding this comment.
Also, is this the same polaris.pem, or a new one. I think it might be better to use a different one here.
| tokenURL = "https://login.microsoftonline.com/%s/oauth2/token" | ||
| managementURL = "https://management.azure.com/subscriptions/%s/resourcegroups/%s?api-version=2016-09-01" | ||
| tokenURL = "https://login.microsoftonline.us/%s/oauth2/token" | ||
| managementURL = "https://management.usgovcloudapi.net/subscriptions/%s/resourcegroups/%s?api-version=2016-09-01" |
There was a problem hiding this comment.
Why change this? Can we run these tests on azure as well after this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Risk Profile
Related Issues
Testing Done
Additional Information