Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Slider): inputs sizes and labels #4841

Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix(Slider): inputs sizes and labels #4841

merged 1 commit into from
Mar 5, 2025

Conversation

matthprost
Copy link
Collaborator

@matthprost matthprost commented Mar 4, 2025

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Fix slider inputs and labels.

Relevant logs and/or screenshots

Page Before After
url Screenshot 2025-03-04 at 11 03 38 Screenshot 2025-03-04 at 11 03 49
url Screenshot 2025-03-04 at 11 04 51 Screenshot 2025-03-04 at 11 05 59

@matthprost matthprost added the bug Something isn't working label Mar 4, 2025
@matthprost matthprost self-assigned this Mar 4, 2025
@matthprost matthprost requested review from johnrazeur, a team and lisalupi as code owners March 4, 2025 13:50
Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 57ff281

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (b599731) to head (57ff281).
Report is 10 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4841      +/-   ##
==========================================
- Coverage   89.21%   89.21%   -0.01%     
==========================================
  Files         230      229       -1     
  Lines        8013     8011       -2     
  Branches     3681     3681              
==========================================
- Hits         7149     7147       -2     
  Misses        864      864              
Files with missing lines Coverage Δ
.../src/components/Slider/components/DoubleSlider.tsx 81.59% <100.00%> (ø)
.../src/components/Slider/components/SingleSlider.tsx 94.73% <100.00%> (+0.11%) ⬆️
packages/ui/src/components/Text/index.tsx 100.00% <ø> (ø)

... and 10 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28288d5...57ff281. Read the comment docs.

@matthprost matthprost requested a review from a team March 4, 2025 14:36
@matthprost matthprost merged commit 5e2164c into main Mar 5, 2025
28 of 29 checks passed
@matthprost matthprost deleted the fix/slider branch March 5, 2025 09:46
@scaleway-bot scaleway-bot mentioned this pull request Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants