Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Banner): component not to have correct image size #4842

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Wrong image size on a banner in small size

Relevant logs and/or screenshots

Page Before After
url Screenshot 2025-03-04 at 15 46 24 Screenshot 2025-03-04 at 15 46 36

@matthprost matthprost added the bug Something isn't working label Mar 4, 2025
@matthprost matthprost requested a review from a team March 4, 2025 14:49
@matthprost matthprost self-assigned this Mar 4, 2025
@matthprost matthprost requested review from johnrazeur and removed request for a team March 4, 2025 14:49
@matthprost matthprost requested a review from lisalupi as a code owner March 4, 2025 14:49
Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: a3de0fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.21%. Comparing base (e2b112c) to head (a3de0fd).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4842   +/-   ##
=======================================
  Coverage   89.21%   89.21%           
=======================================
  Files         230      230           
  Lines        8013     8013           
  Branches     3631     3632    +1     
=======================================
  Hits         7149     7149           
  Misses        864      864           
Files with missing lines Coverage Δ
packages/ui/src/components/Banner/index.tsx 94.28% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2b112c...a3de0fd. Read the comment docs.

@matthprost matthprost merged commit 0450562 into main Mar 5, 2025
16 checks passed
@matthprost matthprost deleted the fix/compact-banner branch March 5, 2025 09:45
@scaleway-bot scaleway-bot mentioned this pull request Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants