Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(InfiniteScroll): new component #4846

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

matthprost
Copy link
Collaborator

@matthprost matthprost commented Mar 6, 2025

Summary

Type

  • Feature

Summarise concisely:

What is expected?

New component <InfiniteScroll /> that allows you to scroll and load data infinitely.

Relevant logs and/or screenshots

Example with a SelectInputV2:

Screen.Recording.2025-03-06.at.18.33.06.mov

Example with a Table:

Screen.Recording.2025-03-06.at.18.35.14.mov

This pull request introduces a new InfiniteScroll component and includes various related updates across multiple files. The changes encompass the addition of the component, its stories, tests, and supporting data.

Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 4d5bbf1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@matthprost matthprost force-pushed the feat/infinite-scroll branch 2 times, most recently from 8464706 to 076f67d Compare March 6, 2025 17:42
@matthprost matthprost self-assigned this Mar 6, 2025
@matthprost matthprost requested review from a team, DorianMaliszewski and JulienSaguez and removed request for a team March 6, 2025 17:45
@matthprost matthprost added the enhancement New feature or request label Mar 6, 2025
@matthprost matthprost marked this pull request as ready for review March 6, 2025 17:45
@matthprost matthprost requested a review from lisalupi as a code owner March 6, 2025 17:45
@matthprost matthprost force-pushed the feat/infinite-scroll branch from 076f67d to e910f8f Compare March 6, 2025 18:01
Copy link

codecov bot commented Mar 6, 2025

Codecov Report

Attention: Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.32%. Comparing base (ec628b1) to head (3eb0a45).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ackages/ui/src/components/InfiniteScroll/index.tsx 94.44% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4846      +/-   ##
==========================================
+ Coverage   89.26%   89.32%   +0.06%     
==========================================
  Files         235      235              
  Lines        8120     8190      +70     
  Branches     3684     3710      +26     
==========================================
+ Hits         7248     7316      +68     
- Misses        872      874       +2     
Files with missing lines Coverage Δ
packages/ui/src/components/Loader/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Stack/index.tsx 100.00% <ø> (ø)
...ackages/ui/src/components/InfiniteScroll/index.tsx 94.44% <94.44%> (ø)

... and 21 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63f9b91...3eb0a45. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants