Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProgressBar): allow value to be above maximum #4855

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matthprost
Copy link
Collaborator

Summary

Type

  • Bug

Summarise concisely:

What is expected?

Current value cannot be shown above the maxium while we want.

Relevant logs and/or screenshots

Page Before After
url Screenshot 2025-03-07 at 16 58 54 Screenshot 2025-03-07 at 16 58 43

@matthprost matthprost added the bug Something isn't working label Mar 7, 2025
@matthprost matthprost requested a review from a team March 7, 2025 16:02
@matthprost matthprost self-assigned this Mar 7, 2025
@matthprost matthprost requested review from BABAK0T0 and removed request for a team March 7, 2025 16:02
@matthprost matthprost requested a review from lisalupi as a code owner March 7, 2025 16:02
@matthprost matthprost requested a review from lisalupi March 7, 2025 16:02
Copy link

changeset-bot bot commented Mar 7, 2025

🦋 Changeset detected

Latest commit: c9dd3a5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.30%. Comparing base (bd30e60) to head (c9dd3a5).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4855      +/-   ##
==========================================
- Coverage   89.30%   89.30%   -0.01%     
==========================================
  Files         234      234              
  Lines        8153     8151       -2     
  Branches     3746     3696      -50     
==========================================
- Hits         7281     7279       -2     
  Misses        872      872              
Files with missing lines Coverage Δ
packages/ui/src/components/ProgressBar/index.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd30e60...c9dd3a5. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants