Skip to content

feature: support mongodb collection sharding #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

rachedbenmustapha
Copy link
Contributor

Support mongodb connection string with sharding, and shard collections when creating a new bucket.

Includes work from #1303

@bert-e
Copy link
Contributor

bert-e commented Nov 5, 2021

Hello rachedbenmustapha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Nov 5, 2021

Incorrect fix version

The Fix Version/s in issue ARSN-28 contains:

  • 8.1.2

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.1.10

Please check the Fix Version/s of ARSN-28, or the target
branch of this pull request.

@bert-e
Copy link
Contributor

bert-e commented Nov 8, 2021

Incorrect fix version

The Fix Version/s in issue ARSN-28 contains:

  • 8.1.10

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.1.11

Please check the Fix Version/s of ARSN-28, or the target
branch of this pull request.

@codecov-commenter
Copy link

Codecov Report

Merging #1624 (48956ca) into development/8.1 (bfbda5d) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           development/8.1    #1624      +/-   ##
===================================================
- Coverage            58.82%   58.80%   -0.02%     
===================================================
  Files                  185      185              
  Lines                11887    11898      +11     
===================================================
+ Hits                  6992     6997       +5     
- Misses                4895     4901       +6     
Impacted Files Coverage Δ
lib/storage/metadata/MetadataWrapper.js 39.20% <ø> (ø)
...orage/metadata/mongoclient/MongoClientInterface.js 37.88% <50.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfbda5d...48956ca. Read the comment docs.

@rachedbenmustapha rachedbenmustapha force-pushed the feature/ARSN-28-mongodb-sharding branch from 48956ca to 77f9719 Compare November 9, 2021 00:57
@rachedbenmustapha
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Nov 9, 2021

Incorrect fix version

The Fix Version/s in issue ARSN-28 contains:

  • 8.1.10

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.1.11

Please check the Fix Version/s of ARSN-28, or the target
branch of this pull request.

The following options are set: approve

@rachedbenmustapha
Copy link
Contributor Author

ping bert-e

@bert-e
Copy link
Contributor

bert-e commented Nov 9, 2021

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.1

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4
  • stabilization/7.10.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Nov 9, 2021

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.1

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • stabilization/7.10.1

Please check the status of the associated issue ARSN-28.

Goodbye rachedbenmustapha.

@bert-e bert-e merged commit 77f9719 into development/8.1 Nov 9, 2021
@bert-e bert-e deleted the feature/ARSN-28-mongodb-sharding branch November 9, 2021 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants