Add mongodb driver checks

[williamlardier]

Catching errors might not be enough: in some cases, a call can succeed yet the result is not what we expect: e.g. no document matching the filters. This leads to inconsistent behaviors where the API thinks the operation succeed while it didn't...

In this PR we identify and fix multiple places where we are ignoring MongoDB return flags. We add the error handling and multiple tests are added, as today some methods are not unit tested at all.

Issue: ARSN-488

[bert-e]

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[bert-e]

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.33%. Comparing base (d79a54b) to head (80fcfbd).

Additional details and impacted files

@@                 Coverage Diff                 @@
##           development/8.1    #2363      +/-   ##
===================================================
+ Coverage            68.69%   69.33%   +0.63%     
===================================================
  Files                  218      218              
  Lines                17533    17573      +40     
  Branches              3579     3612      +33     
===================================================
+ Hits                 12045    12184     +139     
+ Misses                5472     5373      -99     
  Partials                16       16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[williamlardier]

/create_integration_branches

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

The following options are set: create_integration_branches

[bert-e]

History mismatch

Merge commit #2de80d5a6cbb18f8df31a82d3029d2462da8b1e3 on the integration branch
w/8.2/bugfix/ARSN-488 is merging a branch which is neither the current
branch bugfix/ARSN-488 nor the development branch
development/8.2.

It is likely due to a rebase of the branch bugfix/ARSN-488 and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

The following options are set: create_integration_branches

[francoisferrand]

nit:

• this is really a case which "should not" (but does) happen: may be best to keep it as InternalError, possibly customized with an indication of the "mongo" issue (errors.InternalError.customize("mongo failed to match, update and upsert"))
• maybe we can dedup this case of error detection after an update operation, by introducing a processUpdateResult(result, cb) function?