Skip to content

ARTESCA-14759: Fix Flaky UI E2E Tests Due to Local Storage redirectUrl Handling #4543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: development/130.0
Choose a base branch
from
Open

ARTESCA-14759: Fix Flaky UI E2E Tests Due to Local Storage redirectUrl Handling #4543

wants to merge 1 commit into from

Conversation

ChengYanJin
Copy link
Contributor

@ChengYanJin ChengYanJin commented Mar 20, 2025 •
edited
Loading

Component: Shell UI

Context:
We store the redirectUrl in local storage, but this has made the UI end-to-end tests very flaky. Now, we no longer need to store it in local storage—we can keep it in the state instead.

Summary:
By leveraging useNavigate, the UI no longer requires a full reload after login.

Acceptance criteria:

Closes: #ISSUE_NUMBER

@bert-e
Copy link
Contributor

bert-e commented Mar 20, 2025

Hello chengyanjin,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Mar 20, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin
ARTESCA-14759: We store the redirectUrl in the localstorage and this …
0b6daee 
…has become very flaky in the UI e2e test

Now we don't need to store it in the localstorage anymore, we can keep it in the state.
@ChengYanJin ChengYanJin force-pushed the improvement/ARTESCA-14759-fix-UI-e2e-test-flaky branch from bcf10d8 to 0b6daee Compare March 20, 2025 18:09
@ChengYanJin ChengYanJin changed the title ARTESCA-14759: We store the redirectUrl in the localstorage and this has become very flaky in the UI e2e test ARTESCA-14759: Fix Flaky UI E2E Tests Due to Local Storage redirectUrl Handling Mar 21, 2025
@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@ChengYanJin ChengYanJin marked this pull request as ready for review March 21, 2025 11:05
@ChengYanJin ChengYanJin requested a review from a team as a code owner March 21, 2025 11:05
@bert-e
Copy link
Contributor

bert-e commented May 5, 2025

Branches have diverged

This pull request's source branch improvement/ARTESCA-14759-fix-UI-e2e-test-flaky has diverged from
development/130.0 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/130.0 into improvement/ARTESCA-14759-fix-UI-e2e-test-flaky
  • Rebase improvement/ARTESCA-14759-fix-UI-e2e-test-flaky onto origin/development/130.0

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@ChengYanJin
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented May 5, 2025

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e
Copy link
Contributor

bert-e commented May 5, 2025

Branches have diverged

This pull request's source branch improvement/ARTESCA-14759-fix-UI-e2e-test-flaky has diverged from
development/130.0 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/130.0 into improvement/ARTESCA-14759-fix-UI-e2e-test-flaky
  • Rebase improvement/ARTESCA-14759-fix-UI-e2e-test-flaky onto origin/development/130.0

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

@ChengYanJin
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented May 5, 2025

Branches have diverged

This pull request's source branch improvement/ARTESCA-14759-fix-UI-e2e-test-flaky has diverged from
development/130.0 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/130.0 into improvement/ARTESCA-14759-fix-UI-e2e-test-flaky
  • Rebase improvement/ARTESCA-14759-fix-UI-e2e-test-flaky onto origin/development/130.0

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

The following options are set: approve

@ChengYanJin
Copy link
Contributor Author

/reset

@bert-e
Copy link
Contributor

bert-e commented May 5, 2025

Reset complete

I have successfully deleted this pull request's integration branches.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented May 5, 2025

Branches have diverged

This pull request's source branch improvement/ARTESCA-14759-fix-UI-e2e-test-flaky has diverged from
development/130.0 by more than 50 commits.

To avoid any integration risks, please re-synchronize them using one of the
following solutions:

  • Merge origin/development/130.0 into improvement/ARTESCA-14759-fix-UI-e2e-test-flaky
  • Rebase improvement/ARTESCA-14759-fix-UI-e2e-test-flaky onto origin/development/130.0

Note: If you choose to rebase, you may have to ask me to rebuild
integration branches using the reset command.

The following options are set: approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JBWatenbergScality JBWatenbergScality JBWatenbergScality approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChengYanJin @bert-e @JBWatenbergScality