PTFE-1144 gcloud instances support of fixed labels #496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes related to the configuration and testing of custom labels for GCP instances in the runner manager backend. The most important changes include adding a new attribute to the
GCPInstanceConfig
class to configure custom labels, and modifying the GCP backend test to verify the correct setting of custom labels.Main configuration and testing changes:
runner_manager/models/backend.py
: Added a new attributelabels
to theGCPInstanceConfig
class to allow for the configuration of custom labels for GCP instances.tests/unit/backend/test_gcp.py
: Added a new assertion to verify that custom labels are correctly set in thesetup_labels
method of the GCP backend, and modified thegcp_group
method to ensure that a custom label is set for the GCP backend in the test. [1] [2]