Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PTFE-1144 gcloud instances support of fixed labels #496

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Dec 6, 2023

This pull request includes changes related to the configuration and testing of custom labels for GCP instances in the runner manager backend. The most important changes include adding a new attribute to the GCPInstanceConfig class to configure custom labels, and modifying the GCP backend test to verify the correct setting of custom labels.

Main configuration and testing changes:

  • runner_manager/models/backend.py: Added a new attribute labels to the GCPInstanceConfig class to allow for the configuration of custom labels for GCP instances.
  • tests/unit/backend/test_gcp.py: Added a new assertion to verify that custom labels are correctly set in the setup_labels method of the GCP backend, and modified the gcp_group method to ensure that a custom label is set for the GCP backend in the test. [1] [2]

@tcarmet tcarmet requested a review from a team as a code owner December 6, 2023 22:19
@tcarmet tcarmet changed the title PTFE-1144 support of hardcoded label to configure runner groups PTFE-1144 gcloud instances support of fixed labels Dec 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (195e920) 85.44% compared to head (923ed66) 85.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #496      +/-   ##
==========================================
+ Coverage   85.44%   85.45%   +0.01%     
==========================================
  Files          31       31              
  Lines        1168     1169       +1     
==========================================
+ Hits          998      999       +1     
  Misses        170      170              
Flag Coverage Δ
api 66.12% <50.00%> (+0.02%) ⬆️
unit 71.08% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tcarmet tcarmet merged commit 6c1196a into main Dec 7, 2023
12 checks passed
@tcarmet tcarmet deleted the feature/PTFE-1144-support-of-fixed-labels branch December 7, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants