Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not block job from running on runner hooks #678

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

tcarmet
Copy link
Contributor

@tcarmet tcarmet commented Sep 11, 2024

A softer approach to the job started hook checks that runs systematically.
To avoid a situation where those hook might do more harm than good, if they continuously fail after a certain amount of tries, release the runner and let it do its thing.

@tcarmet tcarmet requested a review from a team as a code owner September 11, 2024 20:37
@tcarmet tcarmet force-pushed the feature/PTFE-1988-job-hook-review branch from d672dd1 to f475118 Compare September 11, 2024 20:38
@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.72%. Comparing base (50efe19) to head (f475118).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #678   +/-   ##
=======================================
  Coverage   86.72%   86.72%           
=======================================
  Files          34       34           
  Lines        1431     1431           
=======================================
  Hits         1241     1241           
  Misses        190      190           
Flag Coverage Δ
api 64.91% <ø> (ø)
unit 67.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@liaud liaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I wonder why it couldn't be started in the first place but errors should already be logged, not sure where it went through 🤔

@tcarmet
Copy link
Contributor Author

tcarmet commented Sep 12, 2024

Thank you! I wonder why it couldn't be started in the first place but errors should already be logged, not sure where it went through 🤔

If I remember well it was stuck trying to check if docker was up. Which could be an issue later in the build, but it's better not to get the job blocked for hours due to this. Might as well fail and re-run the job.

@tcarmet tcarmet merged commit e4e66df into main Sep 12, 2024
12 checks passed
@tcarmet tcarmet deleted the feature/PTFE-1988-job-hook-review branch September 12, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants