fix: job hook scripts pre-emptively expands shell parameters #686
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
job_started_script
andjob_completed_script
pre-emptively expand any shell parameters defined in them, resulting in them being expanded when the/opt/runner/job_started_script.sh
and/opt/runner/job_completed_script.sh
files are created and not at runtime of the job.Instructing the heredoc document to skip expanding any shell parameters gives the expected functionality without having to escape them in the config file.