Skip to content

Eyetracking utilization #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 79 commits into from
Oct 29, 2025
Merged

Eyetracking utilization #523

merged 79 commits into from
Oct 29, 2025

Conversation

@smlpt
Copy link
Contributor

@smlpt smlpt commented Jul 6, 2023

Changes made by Ruoshan to implement a bridge for Mastodon tracking to Sciview, as well as utilize eye tracking in Sciview.

RuoshanLan and others added 30 commits August 2, 2021 10:42
@RuoshanLan
utilize eyetracking in sciview
ac16240
@RuoshanLan
a working version and adjust the size of some messages
c3bc1b4
@RuoshanLan
code clean
f1f00c7
@RuoshanLan
let the volume show before starting the eye tracking
9eb458e
@RuoshanLan
update bionic tracking
785eb2c
@RuoshanLan
solve conflict
0c8afc7
@RuoshanLan
add headset for cell tracking
b4f7188
@RuoshanLan
add test without VR headset
0d613f6
@RuoshanLan
a working version of utilizing VRHeadset for cell tracking - part of …
3ddfcfc 
…sandbox function
@RuoshanLan
add function of tracking with controllers
efe9902
@RuoshanLan
replace numerictype with realtype
7370519
@RuoshanLan
resolve conflicts
7e4c128
@RuoshanLan
fix issue in controller version
9fb6c22
@RuoshanLan
improve the VRHeadsSettTrackingDemo and fix a bug caused by UV coordi…
e1c6013 
…nate
@RuoshanLan
add VR interaction to VRHeadSetTrackingDemo and add nodetaggedevent
9348a25
@RuoshanLan
code clean
8aa32f4
@RuoshanLan
merge
3eb8741
@RuoshanLan
Fix line endings
1d59a30
@RuoshanLan
Gradle: Add missing transitive dependencies
a7057b0
@RuoshanLan
SciView: Revert failed merge for addVolume functions
12cd940
@RuoshanLan
clean and add comment
e909c79
@smlpt
Merge branch 'master' into eyetracking-utilization
954ae8e
@smlpt
Gradle Build: update to scenery 0.9.0
3735f6c
@smlpt
Gradle Build: fixing outdated code
1ecaf0f
@smlpt
SciView: bring back openDirTiff and openTrackFile
0a78f66
@smlpt
Gradle: fix directories dep issue
9efcb08
@smlpt
build: update gradle and make the build compatible with java 21
80aeccd
@smlpt
Merge branch 'main' into eyetracking-utilization
f116a80 
# Conflicts:
#	build.gradle.kts
#	gradle/wrapper/gradle-wrapper.jar
#	gradle/wrapper/gradle-wrapper.properties
#	settings.gradle.kts
@smlpt
improve volume loading from scene
8b2839d
@smlpt
fix filtering for volumes in the scene
6136a3c
@smlpt smlpt requested a review from kephale November 19, 2024 10:53
@smlpt
Copy link
Contributor Author

smlpt commented Feb 11, 2025

Any progress on this? @kephale @skalarproduktraum

@smlpt smlpt mentioned this pull request Feb 11, 2025
Closed
@smlpt
Copy link
Contributor Author

smlpt commented May 6, 2025

@skalarproduktraum @kephale poke poke.

The CI fails because we're missing a scenery version that contains a minor feature (message centering for the Camera class).

@kephale
Copy link
Member

kephale commented May 6, 2025

@smlpt do you need that updated in main or can you update that in your branch?

@smlpt
Copy link
Contributor Author

smlpt commented May 7, 2025

@smlpt do you need that updated in main or can you update that in your branch?

I'm not working on this branch anymore, my latest changes are in the controller-tracking branch which I branched out from this one. But since that branch is also close to completion, I thought it makes sense to merge this one first.

And I think @skalarproduktraum wanted this PR to be merged sometime.

The branch works locally because I use a local scenery for it. My message was just to explain why the CI fails here.

@kephale
Copy link
Member

kephale commented May 7, 2025

Aha, got it. Well just ping when you want the full review/merge!

@smlpt
Copy link
Contributor Author

smlpt commented Jun 11, 2025

Would appreciate if this PR could be reviewed and merged to main @skalarproduktraum @kephale (whoever finds time first)

@skalarproduktraum
Copy link
Member

skalarproduktraum commented Jun 11, 2025 •
edited
Loading

Hi @smlpt! Happy to review, but in the current state, the CI doesn't run through with compilation errors. Please fix this, and then I'm more than happy to review and merge 🚢

@kephale
Copy link
Member

kephale commented Jun 11, 2025

Also happy to review and see this merged! If you ping when the CI is working I'll try to check it out asap

@smlpt
Copy link
Contributor Author

smlpt commented Jun 12, 2025

@skalarproduktraum we will need a new scenery release then to fix the CI (see above comments)

@smlpt
Copy link
Contributor Author

smlpt commented Jul 17, 2025 •
edited
Loading

Edit: these classes were removed from the PR now.

There are a few classes from Ruoshans original project that made their way into the PR and can maybe also be removed, but I'm not sure. At least they are not used for the current manvr3d features. These include:

  • OpenTrackFile
  • NodeTaggedEvent
  • EyeTrackingCommand (original purpose was as standalone sciview usage, but now EyeTracking relies on callbacks to Mastodon)
  • TrackingDragBehavior (looks like it was never implemented by Ruoshan)
  • TrackingTest (legacy code for reading a CSV and building tracks in sciview. Not connected to Mastodon)
  • TrackingTestCommand
  • VRControllerTracking (uses the controller direction instead of the gaze direction to track cells. Not updated to work with Mastodon because we use a different kind of controller tracking)
  • VRControllerTrackingCommand
  • VRHeadsetTracking (I see no real use for this over eye tracking. head movement instead of eye movement is probably even more confusing to use for tracking)
  • VRHeadsetTrackingCommand

@smlpt smlpt mentioned this pull request Oct 23, 2025
Closed
skalarproduktraum
skalarproduktraum requested changes Oct 29, 2025
View reviewed changes
Copy link
Member

@skalarproduktraum skalarproduktraum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from some minor cleanup stuff, looks good to me 👍

@smlpt
Copy link
Contributor Author

smlpt commented Oct 29, 2025

@skalarproduktraum thanks for the review! All changes addressed. I added the ConfirmableClickBehavior class to the change list for the manvr3d refactor.

Since I have a branch that was branched from this one, is a rebase still advisable? Or should we merge instead?

@skalarproduktraum skalarproduktraum merged commit 3803d84 into main Oct 29, 2025
3 of 4 checks passed
@skalarproduktraum skalarproduktraum deleted the eyetracking-utilization branch October 29, 2025 18:04
@smlpt smlpt mentioned this pull request Oct 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skalarproduktraum skalarproduktraum skalarproduktraum requested changes

@kephale kephale Awaiting requested review from kephale

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@smlpt @kephale @skalarproduktraum @RuoshanLan