-
Notifications
You must be signed in to change notification settings - Fork 201
ci: implement selective test matrix based on changed files #2958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hodgesds
wants to merge
1
commit into
sched-ext:main
Choose a base branch
from
hodgesds:ci-selective-test-matrix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+393
−27
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # GitHub Actions CI Scripts | ||
|
|
||
| ## list-integration-tests.py | ||
|
|
||
| Generates the test matrix for integration tests with intelligent filtering based on changed files. | ||
|
|
||
| ### How It Works | ||
|
|
||
| 1. **Detects Changed Files**: Uses `git diff` to find files changed between the PR branch and the base branch. | ||
|
|
||
| 2. **Categorizes Changes**: | ||
| - **Core changes**: Files in `rust/scx_utils/`, `rust/scx_stats/`, `.github/`, `.nix/`, etc. | ||
| - **Library changes**: Files in `rust/scx_rustland_core/` or other local dependencies | ||
| - **Scheduler changes**: Files in `scheds/rust/scx_*/` | ||
|
|
||
| 3. **Builds Dependency Graph**: Parses `Cargo.toml` files to understand which schedulers depend on which libraries. | ||
|
|
||
| 4. **Generates Filtered Matrix**: | ||
| - Core changes → Test all schedulers | ||
| - Library changes → Test schedulers that depend on that library | ||
| - Scheduler changes → Test only that scheduler | ||
| - Mixed changes → Test union of affected schedulers | ||
|
|
||
| ### Forcing Full Test Runs | ||
|
|
||
| If you need to test all schedulers regardless of changes, you can: | ||
|
|
||
| 1. **Commit trailer method**: Add to your commit message: | ||
| ``` | ||
| CI-Test-Kernel: sched_ext/for-next | ||
| ``` | ||
|
|
||
| 2. **Modify core files**: Touch a file like `.github/workflows/caching-build.yml` to trigger full tests | ||
|
|
||
| ### Testing Locally | ||
|
|
||
| Run the test script: | ||
| ```bash | ||
| .github/include/test-selective-matrix.sh | ||
| ``` | ||
|
|
||
| Or manually: | ||
| ```bash | ||
| # Simulate PR context | ||
| export GITHUB_BASE_REF=main | ||
| python3 .github/include/list-integration-tests.py sched_ext/for-next | ||
| ``` | ||
|
|
||
| ### Matrix Output Format | ||
|
|
||
| The script outputs a JSON array of objects: | ||
| ```json | ||
| [ | ||
| {"name": "scx_bpfland", "flags": "", "kernel": ""}, | ||
| {"name": "scx_layered", "flags": "--disable-topology=false", "kernel": ""} | ||
| ] | ||
| ``` | ||
|
|
||
| This is consumed by the GitHub Actions workflow to create the test matrix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we could invert this? I wonder whether it would be better to say that changes in
scheds/rustdon't necessarily run everything, but every other change does. This list scares me a bit!