Update NERSC instructions in README.md#3
Open
p-slash wants to merge 2 commits intoschoeneberg:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated the installation instructions. I find that removing the linker is not needed, but you need to slightly adjust the Makefile of class.
make -jinstalls the python package in a deprecated way (python setup.py installis far gone). So I think class should be compiled, then python module should be installed separately with pip install. I changed lym1d installation to editable.In the future, we might want to load the CPU module first in the beginning if we are going to use CPUs for analysis. This might enable further small optimizations by the compiler.