Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test case name #766

Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix test case name #766

merged 1 commit into from
Jul 29, 2024

Conversation

tnothy
Copy link
Contributor

@tnothy tnothy commented Jul 28, 2024

Seems like the test was ignored when running go test due to lowercase test.

Results of go test -json ./src/croc/ | jq -s 'map(select(.Test and .Action == "pass")) | length'
Before: 6
After: 7

Copy link

@x64x2 x64x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't fix anything

@tnothy
Copy link
Contributor Author

tnothy commented Jul 29, 2024

I believe that right now, with the test function starting with a lower case letter the test is not executed

@schollz schollz merged commit dccd6fe into schollz:main Jul 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants