Validate options (#34)

* added options validation * renamed :other-metrices -> :other-metrics
scicloj · Jan 27, 2025 · 79a3d1a · 79a3d1a
1 parent 90f2f62
commit 79a3d1a
Show file tree

Hide file tree

Showing 20 changed files with 189 additions and 163 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -47,7 +47,7 @@ jobs:
         uses: quarto-dev/quarto-actions/setup@v2
       # Runs a single command using the runners shell
       - name: Run CI
-        run: clojure -T:build ci
+        run: clojure -X:deps prep :aliases [:test] && clojure -T:build ci
 
       - name: copy news data   
         run: |

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,6 @@
 unreleased
-
-
-
+* use malli to describe options
+* renamed :other-metrices -> :other-metrics
 
 0.12
 * fixes #30 - dummy classifier does not predict by majority #30

diff --git a/deps.edn b/deps.edn
@@ -50,7 +50,11 @@
   {:jvm-opts ["-Djava.awt.headless=true"] 
    :extra-deps {io.github.nextjournal/clerk {:mvn/version "0.17.1102"}
                 org.scicloj/clay {:mvn/version "2-beta27"}
-                org.scicloj/scicloj.ml.smile {:mvn/version "7.4.4"}
+                org.scicloj/scicloj.ml.smile
+                {:git/url "https://github.com/scicloj/scicloj.ml.smile"
+                 :git/sha "b302bd8846a5f99abfb92276c3b8c09fd91b4a92"}
+                ;{:mvn/version "7.4.4"}
+
                 org.scicloj/tableplot {:mvn/version "1-beta1.1"}
                 datacraft-sciences/confuse {:mvn/version "0.1.1"}
                 ch.qos.logback/logback-classic {:mvn/version "1.5.16"}
@@ -62,19 +66,29 @@
    :extra-paths ["test"]
    :extra-deps {com.clojure-goes-fast/clj-memory-meter {:mvn/version "0.3.0"}
                 lambdaisland/kaocha {:mvn/version "1.91.1392"}
-                org.scicloj/scicloj.ml.smile {:mvn/version "7.4.4"}
+                ;org.scicloj/scicloj.ml.smile {:mvn/version "7.4.4"}
+                org.scicloj/scicloj.ml.smile
+                {:git/url "https://github.com/scicloj/scicloj.ml.smile"
+                 :git/sha "b302bd8846a5f99abfb92276c3b8c09fd91b4a92"}
+
+                criterium/criterium {:mvn/version  "0.4.6"}
+
                 datacraft-sciences/confuse {:mvn/version "0.1.1"}
                 ch.qos.logback/logback-classic {:mvn/version "1.5.16"}
-                org.mapdb/mapdb {:mvn/version "3.1.0"}
-                }}
+                org.mapdb/mapdb {:mvn/version "3.1.0"}}}
   :runner {:main-opts ["-m" "kaocha.runner"]}
 
   :exp {:jvm-opts ["-Djdk.attach.allowAttachSelf" "-Xmx8G" "--add-opens=java.base/java.io=ALL-UNNAMED"]
         :extra-paths ["exp" "test"]
         :extra-deps {com.clojure-goes-fast/clj-memory-meter {:mvn/version "0.3.0"}
                      ch.qos.logback/logback-classic {:mvn/version "1.5.16"}
                      criterium/criterium {:mvn/version  "0.4.6"}
-                     org.scicloj/scicloj.ml.smile {:mvn/version "7.4.4"}
+
+                     org.scicloj/scicloj.ml.smile
+                     {:git/url "https://github.com/scicloj/scicloj.ml.smile"
+                      :git/sha "b302bd8846a5f99abfb92276c3b8c09fd91b4a92"}
+
+                     ;;org.scicloj/scicloj.ml.smile {:mvn/version "7.4.4"}
                      com.taoensso/carmine {:mvn/version "3.4.1"}}}
 
   :smoke-test {:jvm-opts ["-Djdk.attach.allowAttachSelf" "-Xmx1G" "--add-opens=java.base/java.io=ALL-UNNAMED"]

diff --git a/notebooks/roc_curve.clj b/notebooks/roc_curve.clj
@@ -1,19 +1,11 @@
 (ns roc-curve
   (:require
-     [nextjournal.clerk :as clerk]
-     [scicloj.metamorph.core :as mm]
-     [scicloj.metamorph.ml :as ml]
-     [scicloj.metamorph.ml.learning-curve :as lc]
-     [scicloj.metamorph.ml.viz :as ml-viz]
-     [scicloj.metamorph.ml.viz.learning-curve :as mlviz.lc]
+   [nextjournal.clerk :as clerk]
    [scicloj.metamorph.ml.metrics :as m]
    [nextjournal.clerk.viewer]
-   [tablecloth.api :as tc]
    [scicloj.metamorph.ml.loss]
    [scicloj.ml.smile.classification]
-   [tablecloth.pipeline :as tc-mm]
-   [tech.v3.dataset]
-   [tech.v3.dataset.metamorph :as mds]))
+   [tech.v3.dataset]))
 
 (comment
   (clerk/clear-cache!)