image to events function added #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11 +/- ##
==========================================
+ Coverage 59.13% 61.01% +1.87%
==========================================
Files 4 4
Lines 394 413 +19
==========================================
+ Hits 233 252 +19
Misses 161 161
Continue to review full report at Codecov.
|
awalter-bnl
approved these changes
Jul 17, 2018
rixs/process2d.py
Outdated
| @@ -217,6 +219,7 @@ def photon_events_to_image(photon_events, bins=None): | |||
| 1D vector describing column position | |||
| y_centers : array | |||
| 1D vector describing row position | |||
| +ve y is up convetion is applied. | |||
There was a problem hiding this comment.
convention is mispelt here
There was a problem hiding this comment.
This is corrected in the subsequent commit.
|
@awalter-bnl Can we merge this? |
|
I have merged this as it is a small PR and has been waiting for 4 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A function converting 2D data arrays (images) to three column events function was added.
y values are now returned high to low to impose the convention that +ve y is run consistent with widely used RIXS conventions and with matplotlib scatter and pcolor functions.