-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binning changes #19
Binning changes #19
Conversation
Codecov Report
@@ Coverage Diff @@
## master #19 +/- ##
==========================================
+ Coverage 63.19% 63.91% +0.71%
==========================================
Files 4 4
Lines 413 424 +11
==========================================
+ Hits 261 271 +10
- Misses 152 153 +1
Continue to review full report at Codecov.
|
I'm having trouble understanding why the tests don't pass as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look OK to me
@awalter-bnl Can you understand why the tests aren't working now? |
@mpmdean this relates to codecov, not the pytest functions that are written directly. As a simplified explanation codecov looks at each line of code and checks if that line is To make them pass the best option is to work out which lines of code are not being executed with the 'testing' and write some more tests, or extend existing tests, so that these lines will be tested. In this case I would do the following:
|
The tests are added. Maybe we can merge now since I think the chances of others reviewing this isn't very high. |
These updates relate to PR #48 on sixtools. This implemented a change to the default binning and allows the code to keep track of the binning even if one wants to crop images with a ROI. This is helpful because it allows sixtools to return directly comparable data from either images or centroided data.