Add new curvature optimization code #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an issue with the new test function which is failing. Once that has been resolved I am happy with this change. |
Codecov Report
@@ Coverage Diff @@
## master #20 +/- ##
=========================================
+ Coverage 63.91% 66.22% +2.3%
=========================================
Files 4 4
Lines 424 450 +26
=========================================
+ Hits 271 298 +27
+ Misses 153 152 -1
Continue to review full report at Codecov.
|
|
The tests now pass. |
awalter-bnl
approved these changes
Jan 2, 2019
|
Just a drive-by comment: This looks super clean and easy to understand/maintain. Thank you for the docstrings and the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is for optimizing the curvature based on minimizing the fitted gaussian width of the spectrum.