feat: pickle in native byteorder and pass byteorder through pickling and unpickling#3893
Open
ikrommyd wants to merge 5 commits intoscikit-hep:mainfrom
Open
feat: pickle in native byteorder and pass byteorder through pickling and unpickling#3893ikrommyd wants to merge 5 commits intoscikit-hep:mainfrom
ikrommyd wants to merge 5 commits intoscikit-hep:mainfrom
Conversation
|
The documentation preview is ready to be viewed at http://preview.awkward-array.org.s3-website.us-east-1.amazonaws.com/PR3893 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
🚀 New features to boost your workflow:
|
Collaborator
Author
|
This has to be a new "schema 2" in order to be able to unpickle files pickled with previous versions of awkward as the unpickling function is accessed by module and function name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If one pickles and unpickles in-memory in a big-endian system, it currently requires two copies. We prevent that by always pickling in the native byteorder. Also in that case, a pickle file created in a system of opposite endianess, will be unpickled incorrectly. We encode the endianess information of the system that the pickle was created inside the pickle so that the system doing the unpickling, knows what byteorder to use when interpreting the bytes.