feat: add overloads for some awkward reducers for coffea's vectors - #1622
Open
ikrommyd wants to merge 2 commits into
Open
feat: add overloads for some awkward reducers for coffea's vectors#1622ikrommyd wants to merge 2 commits into
ikrommyd wants to merge 2 commits into
Conversation
Member
Author
|
cc @kpedro88 you can try this one out. |
Contributor
|
This works, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1620
Adds overloads for
ak.sum,ak.countandak.count_nonzeroon vectors coffea defines. The overloads for count and count nonzero are taken directly from scikit-hep/vector while for sum we use coffea's ownsummethod that its vectors define since we also need to deal with charge which scikit-hep/vector does not deal with.