Skip to content

Fix DecFileParser.expand_decay_modes method - #634

Merged
eduardo-rodrigues merged 1 commit into
mainfrom
eduardo-fix-expand_decay_modes
Oct 12, 2026
Merged

eduardo-rodrigues merged 1 commit into
mainfrom
eduardo-fix-expand_decay_modes

Conversation

@eduardo-rodrigues

Copy link
Copy Markdown
Member

Hello @admorris, a while back you had reported that for example using the LHCb decay file Bc_excitedtrueCharmoniumTauNu,charmonium+=cocktail,mm,pipipi=DecProdCut,CntCut.dec the new DecFileParser.expand_decay_modes(...) function was not correctly resolving all aliases. You say "so far I've only seen it with neutral unflavoured mesons, so it might be a clash beween the unaliasing and charge-conjugation".

It turns out the issue is that aliases were only resolved for decay mothers, not the final-state particles. I fixed this now via this PR, and added a comprehensive set of tests + improved the docs a bit (the fix itself is a one-liner).

@codecov

codecov Bot commented Oct 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.04%. Comparing base (e6e1fe1) to head (02034f9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files           6        6           
  Lines        1276     1276           
=======================================
  Hits         1251     1251           
  Misses         25       25           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eduardo-rodrigues
eduardo-rodrigues merged commit 27c4d68 into main Oct 12, 2026
18 checks passed
@eduardo-rodrigues
eduardo-rodrigues deleted the eduardo-fix-expand_decay_modes branch October 12, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant