Skip to content

Conversation

ariostas
Copy link
Collaborator

@ariostas ariostas commented Aug 1, 2025

This PR improves the show method on RNTuple so that it better shows the structure. This was inspired by UnROOT, which does a much better job of displaying the contents of an RNTuple.

This change breaks the api, but I think it's fine since show is something you would only use interactively and not in some existing script.

I still have to do some polishing and maybe add colors.

@ianna ianna added the next-release Required for the next release label Aug 14, 2025
@ariostas
Copy link
Collaborator Author

ariostas commented Sep 4, 2025

I added **kwargs just no not break the api, and I fixed the docstring. I think it's not worth adding color since that might complicate things and might not always work.

@ariostas ariostas marked this pull request as ready for review September 4, 2025 18:45
@ariostas ariostas requested a review from ianna September 4, 2025 18:45
Copy link
Collaborator

@ianna ianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ariostas - looks good to me. Thanks! I’m not sure why docs are failing though.

@ariostas
Copy link
Collaborator Author

ariostas commented Sep 4, 2025

@jpivarski or @agoose77 could you please add Ianna and me as maintainers in ReadTheDocs? The build randomly fails, so it would be nice to be able to retry it easily.

@jpivarski
Copy link
Member

I added you, @ariostas, but I don't know @ianna's ReadTheDocs account (or the associated email address; I tried all the email addresses that I know).

image

@ariostas
Copy link
Collaborator Author

ariostas commented Sep 4, 2025

Thank you, Jim!

@ianna
Copy link
Collaborator

ianna commented Sep 5, 2025

I added you, @ariostas, but I don't know @ianna's ReadTheDocs account (or the associated email address; I tried all the email addresses that I know).

image

Thanks @jpivarski ! I have an account linked to my GitHub and cern email ianna dot osborne at cern dot ch

@jpivarski
Copy link
Member

That's an email address that I tried, among with your GMail and Princeton ones. Do you log into ReadTheDocs (.org) using your GitHub account? If so, your GitHub username should have worked, but that didn't either.

@ianna
Copy link
Collaborator

ianna commented Sep 5, 2025

That's an email address that I tried, among with your GMail and Princeton ones. Do you log into ReadTheDocs (.org) using your GitHub account? If so, your GitHub username should have worked, but that didn't either.

Could you please try again? Thanks

@ariostas
Copy link
Collaborator Author

ariostas commented Sep 5, 2025

@ianna I just added you and it seems to have worked

@ianna ianna merged commit ee0ca89 into main Sep 5, 2025
26 checks passed
@ianna ianna deleted the ariostas/better_rntuple_display branch September 5, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release Required for the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants