-
Notifications
You must be signed in to change notification settings - Fork 84
feat: better show method for RNTuples #1482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ariostas - looks good to me. Thanks! I’m not sure why docs are failing though.
@jpivarski or @agoose77 could you please add Ianna and me as maintainers in ReadTheDocs? The build randomly fails, so it would be nice to be able to retry it easily. |
Thank you, Jim! |
Thanks @jpivarski ! I have an account linked to my GitHub and cern email ianna dot osborne at cern dot ch |
That's an email address that I tried, among with your GMail and Princeton ones. Do you log into ReadTheDocs (.org) using your GitHub account? If so, your GitHub username should have worked, but that didn't either. |
Could you please try again? Thanks |
@ianna I just added you and it seems to have worked |
This PR improves the show method on RNTuple so that it better shows the structure. This was inspired by UnROOT, which does a much better job of displaying the contents of an RNTuple.
This change breaks the api, but I think it's fine since
show
is something you would only use interactively and not in some existing script.I still have to do some polishing and maybe add colors.