Skip to content
This repository was archived by the owner on Dec 6, 2023. It is now read-only.

migrate to GitHub Actions #179

Merged
merged 5 commits into from
May 28, 2021
Merged

migrate to GitHub Actions #179

merged 5 commits into from
May 28, 2021

Conversation

StrikerRUS
Copy link
Contributor

@StrikerRUS StrikerRUS commented May 20, 2021

Unified "in-house" solution.

  • Test package on macOS
  • No need to maintain multiple CIs
    • One config file for all three OSes (Linux, macOS, Windows)
    • No need to think about adding new collaborators to third-party sites: repository maintainers are already have enough rights to re-run GitHub Actions jobs
    • No dependency on operating status of third-party services
    • No need to give any rights to third-party services
    • All reports are stored on a tab "Actions", one-click far from the main page of repository
  • Appveyor offers only one parallel job on free tier (GitHub Actions - 20 total concurrent jobs, but 5 for macOS; more info here)
  • Travis was not very friendly to open-source projects recently: [RFC] Travis adding much stricter limits on free users microsoft/LightGBM#3519

Closed #118.

@StrikerRUS StrikerRUS requested review from mblondel and vene May 20, 2021 14:54
Comment on lines +53 to +60
- name: Check Python version
shell: python
run: |
import struct
import sys

assert sys.version_info[:2] == tuple(map(int, "${{ matrix.python_version }}".split(".")))
assert f"x{struct.calcsize('P') * 8}".replace("32", "86") == "${{ matrix.python_arch }}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check that this stuff works:

https://github.com/StrikerRUS/lightning/commit/340aa6aff902c472ab6b60c7226a07d26f4996d5
and corresponding to the commit above workflow run (note that all x86 jobs fail): https://github.com/StrikerRUS/lightning/actions/runs/860558934

@mblondel
Copy link
Member

LGTM, thank you

@StrikerRUS StrikerRUS merged commit a97ce6c into scikit-learn-contrib:master May 28, 2021
@StrikerRUS StrikerRUS deleted the github_actions branch June 6, 2021 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants