NF: Autoencoder FINTA ConvNext#246
Open
AntoineTheb wants to merge 16 commits intoscil-vital:masterfrom
Open
Conversation
… into add_autoencoder_streamlines
|
Hello @AntoineTheb, Thank you for updating ! There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-10-03 21:03:57 UTC |
AntoineTheb
changed the title
levje
approved these changes
Oct 3, 2024
arnaudbore
approved these changes
Oct 7, 2024
Collaborator
arnaudbore
left a comment
arnaudbore
left a comment
There was a problem hiding this comment.
LGTM - Either we wait for latent space viz before merging or Jeremi or I could add it after merging.
| @@ -0,0 +1,136 @@ | |||
| #!/usr/bin/env python | |||
| # -*- coding: utf-8 -*- | |||
Collaborator
There was a problem hiding this comment.
Rename to ae_autoencode_tractogram.py
| "as a data per point (color)") | ||
|
|
||
| # Additional arg for projects | ||
| p.add_argument('--model', type=str, choices=['finta', 'convnext'], |
Collaborator
There was a problem hiding this comment.
Put it as a mandatory argument.
Collaborator
Author
|
@arnaudbore don't wait for me I'll be busy with MICCAI then vacations so I'll rebase and adjust once @levje's pr is merged |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs, but you will still be able to re-open it. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a new autoencoder model inspired by ConvNext: https://arxiv.org/abs/2201.03545
Testing data and script
Ask Arnaud for data
Have you
People this PR concerns