chore: migrate to golangci-lint v2

.golangci.yml

@@ -0,0 +1,111 @@
+version: "2"
+run:
+  skip-dirs:
+    - ^doc/
+  timeout: 3m
+linters:
+  default: none
+  enable:
+    - contextcheck
+    - copyloopvar
+    - errcheck
+    - forbidigo
+    - goheader
+    - govet
+    - ineffassign
+    - lll
+    - misspell
+    - rowserrcheck
+    - sqlclosecheck
+    - staticcheck
+    - unconvert
+    - unused
+  settings:
+    staticcheck:
+      checks:
+        - all
+        - "-QF1001" # disable "Apply De Morgan's law".
+        # The use of Go ideomatic identifiers is a recommendation, not a law.
+        - "-ST1003" # disable "Poorly chosen identifier".
+        - "-QF1008" # disable "Omit embedded fields from selector expression".
+    errcheck:
+      exclude-functions:
+        - (*github.com/spf13/cobra.Command).MarkFlagRequired
+    forbidigo:
+      forbid:
+        - pattern: ([iI][fF][iI]d)|([iI]F[iI][dD])|([iI][fF]i[dD])
+          msg: spell interface ID as ifID / IfID
+        - pattern: (?i)interfaceID
+          msg: spell interface ID as ifID / IfID
+        - pattern: Trc
+          msg: spell trust root certificate as trc / TRC
+    goheader:
+      values:
+        regexp:
+          copyright-lines: |-
+            (Copyright 20[0-9][0-9] .*)(
+            Copyright 20[0-9][0-9] .*)*
+      template: |-
+        {{copyright-lines}}
+
+        Licensed under the Apache License, Version 2.0 (the "License");
+        you may not use this file except in compliance with the License.
+        You may obtain a copy of the License at
+
+          http://www.apache.org/licenses/LICENSE-2.0
+
+        Unless required by applicable law or agreed to in writing, software
+        distributed under the License is distributed on an "AS IS" BASIS,
+        WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+        See the License for the specific language governing permissions and
+        limitations under the License.
+    lll:
+      line-length: 100
+      tab-width: 4
+  exclusions:
+    generated: lax
+    presets:
+      - comments
+      - common-false-positives
+      - legacy
+      - std-error-handling
+    rules:
+      - linters:
+          - lll
+        source: http[s]://\S{80,}$
+      - linters:
+          - lll
+        source: '`(yaml|toml|json):"[^`]*`$'
+      - linters:
+          - goheader
+        path: pkg/private/util/duration.go
+      - linters:
+          - errcheck
+          - goheader
+        path: pkg/private/serrors/stack.go
+      - linters:
+          - errcheck
+          - goheader
+          - lll
+        path: scion-pki/certs/(certinfo|certformat).go
+      - linters:
+          - goheader
+        path: pkg/scrypto/cms
+    paths:
+      - third_party$
+      - builtin$
+      - examples$
+formatters:
+  enable:
+    - gofmt
+    - goimports
+  settings:
+    goimports:
+      local-prefixes:
+        - github.com/scionproto/scion
+  exclusions:
+    generated: lax
+    paths:
+      - third_party$
+      - builtin$
+      - examples$

Makefile

@@ -123,7 +123,7 @@ GO_BUILD_TAGS_ARG=$(shell bazel info --ui_event_filters=-stdout,-stderr --announ
 
 lint-go-golangci:
 	$(info ==> $@)
-	@tools/quiet bazel run --config=quiet @rules_go//go -- run github.com/golangci/golangci-lint/cmd/golangci-lint@v1.64.8 run --config="${PWD}/.golangcilint.yml" --timeout=3m $(GO_BUILD_TAGS_ARG),lint --exclude-dirs doc ./...
+	@tools/quiet bazel run --config=quiet @rules_go//go -- run github.com/golangci/golangci-lint/v2/cmd/golangci-lint@v2.1.6 run --config="${PWD}/.golangci.yml" $(GO_BUILD_TAGS_ARG),lint ./...
 
 lint-go-semgrep:
 	$(info ==> $@)

acceptance/router_benchmark/brload/main.go

@@ -51,7 +51,7 @@ func (c *caseChoice) String() string {
 func (c *caseChoice) Set(v string) error {
 	_, ok := allCases[v]
 	if !ok {
-		return errors.New("No such case")
+		return errors.New("no such case")
 	}
 	*c = caseChoice(v)
 	return nil

acceptance/topo_cs_reload/reload_test.go

@@ -90,10 +90,13 @@ func setupTest(t *testing.T) testState {
 	s := testState{
 		extraEnv: []string{"TOPO_CS_RELOAD_CONFIG_DIR=" + tmpDir},
 	}
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4775).
 	scionPKI, err := bazel.Runfile(*scionPKILocation)
 	require.NoError(t, err)
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4775).
 	cryptoLib, err := bazel.Runfile(*cryptoLibLocation)
 	require.NoError(t, err)
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4775).
 	topoFile, err := bazel.Runfile(*topoLocation)
 	require.NoError(t, err)
 	s.mustExec(t, *genCryptoLocation, scionPKI, "crypto.tar", topoFile, cryptoLib)

control/beaconing/extender_test.go

@@ -93,6 +93,7 @@ func TestDefaultExtenderExtend(t *testing.T) {
 			// Setup interfaces with active parent, child and one peer interface.
 			intfs := ifstate.NewInterfaces(interfaceInfos(topo), ifstate.Config{})
 			for _, peer := range tc.peers {
+				//nolint:staticcheck // SA1019: Activate is fine for testing.
 				intfs.Get(peer).Activate(peerRemoteIfs[peer])
 			}
 			ext := &beaconing.DefaultExtender{

control/beaconing/writer.go

@@ -113,7 +113,7 @@ func (r *WriteScheduler) Run(ctx context.Context) {
 }
 
 func (r *WriteScheduler) run(ctx context.Context) error {
-	if !(r.Tick.Overdue(r.lastWrite) || r.Tick.Passed()) {
+	if !r.Tick.Overdue(r.lastWrite) && !r.Tick.Passed() {
 		return nil
 	}
 	segments, err := r.Provider.SegmentsToRegister(ctx, r.Type)

control/cmd/control/main.go

@@ -488,6 +488,8 @@ func realMain(ctx context.Context) error {
 				},
 			}
 			// Periodically check the connection to the CA backend
+			// SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
+			//nolint:staticcheck
 			caHealthChecker := periodic.Start(
 				periodic.Func{
 					TaskName: "ca healthcheck",
@@ -519,6 +521,7 @@ func realMain(ctx context.Context) error {
 	}
 
 	// Frequently regenerate signers to catch problems, and update the metrics.
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 	periodic.Start(
 		periodic.Func{
 			TaskName: "signer generator",
@@ -537,6 +540,7 @@ func realMain(ctx context.Context) error {
 		5*time.Second,
 	)
 
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 	trcRunner := periodic.Start(
 		periodic.Func{
 			TaskName: "trc expiration updater",

control/drkey/grpc/drkey_service.go

@@ -333,8 +333,8 @@ func validateHostHostReq(meta drkey.HostHostMeta, localIA addr.IA, peerAddr net.
 	srcHost := net.ParseIP(meta.SrcHost)
 	dstHost := net.ParseIP(meta.DstHost)
 
-	if !((meta.SrcIA.Equal(localIA) && hostAddr.Equal(srcHost)) ||
-		(meta.DstIA.Equal(localIA) && hostAddr.Equal(dstHost))) {
+	if (!meta.SrcIA.Equal(localIA) || !hostAddr.Equal(srcHost)) &&
+		(!meta.DstIA.Equal(localIA) || !hostAddr.Equal(dstHost)) {
 		return serrors.New(
 			"invalid request",
 			"local_isd_as", localIA,

control/drkey/grpc/fetcher_test.go

@@ -157,7 +157,8 @@ func genCrypto(t testing.TB) string {
 		"--isd-dir",
 		"--as-validity", "1y",
 	})
-	cmd.SetOutput(&buf)
+	cmd.SetOut(&buf)
+	cmd.SetErr(&buf)
 	err := cmd.Execute()
 	require.NoError(t, err, buf.String())
 

control/tasks.go

@@ -97,6 +97,7 @@ func (t *TasksConfig) Originator() *periodic.Runner {
 	if t.Metrics != nil {
 		s.Originated = metrics.NewPromCounter(t.Metrics.BeaconingOriginatedTotal)
 	}
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 	return periodic.Start(s, 500*time.Millisecond, t.OriginationInterval)
 }
 
@@ -118,6 +119,7 @@ func (t *TasksConfig) Propagator() *periodic.Runner {
 		p.Propagated = metrics.NewPromCounter(t.Metrics.BeaconingPropagatedTotal)
 		p.InternalErrors = metrics.NewPromCounter(t.Metrics.BeaconingPropagatorInternalErrorsTotal)
 	}
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 	return periodic.Start(p, 500*time.Millisecond, t.PropagationInterval)
 }
 
@@ -199,6 +201,7 @@ func (t *TasksConfig) segmentWriter(segType seg.Type,
 	// as we can until we succeed. After succeeding, the task does nothing
 	// until the end of the interval. The interval itself is used as a
 	// timeout. If we fail slow we give up at the end of the cycle.
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 	return periodic.Start(r, 500*time.Millisecond, t.RegistrationInterval)
 }
 
@@ -236,6 +239,7 @@ func (t *TasksConfig) DRKeyCleaners() []*periodic.Runner {
 	cleaners := t.DRKeyEngine.CreateStorageCleaners()
 	cleanerTasks := make([]*periodic.Runner, len(cleaners))
 	for i, cleaner := range cleaners {
+		//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 		cleanerTasks[i] = periodic.Start(cleaner, cleanerPeriod, cleanerPeriod)
 	}
 	return cleanerTasks
@@ -246,6 +250,7 @@ func (t *TasksConfig) DRKeyPrefetcher() *periodic.Runner {
 		return nil
 	}
 	prefetchPeriod := t.DRKeyEpochInterval / 2
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 	return periodic.Start(
 		&drkey.Prefetcher{
 			LocalIA:     t.IA,
@@ -276,6 +281,7 @@ func StartTasks(cfg TasksConfig) (*Tasks, error) {
 		Originator: cfg.Originator(),
 		Propagator: cfg.Propagator(),
 		Registrars: cfg.SegmentWriters(),
+		//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 		PathCleaner: periodic.Start(
 			periodic.Func{
 				Task: func(ctx context.Context) {

control/trust/main_test.go

@@ -37,7 +37,8 @@ func genCrypto(t *testing.T) string {
 		"--isd-dir",
 		"--as-validity", "1y",
 	})
-	cmd.SetOutput(&buf)
+	cmd.SetOut(&buf)
+	cmd.SetErr(&buf)
 	err := cmd.Execute()
 	require.NoError(t, err, buf.String())
 

daemon/cmd/daemon/main.go

@@ -117,9 +117,11 @@ func realMain(ctx context.Context) error {
 	})
 	defer pathDB.Close()
 	defer revCache.Close()
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 	cleaner := periodic.Start(pathdb.NewCleaner(pathDB, "sd_segments"),
 		300*time.Second, 295*time.Second)
 	defer cleaner.Stop()
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 	rcCleaner := periodic.Start(revcache.NewCleaner(revCache, "sd_revocation"),
 		10*time.Second, 10*time.Second)
 	defer rcCleaner.Stop()
@@ -169,6 +171,7 @@ func realMain(ctx context.Context) error {
 		Dir: filepath.Join(globalCfg.General.ConfigDir, "certs"),
 		DB:  trustDB,
 	}
+	//nolint:staticcheck // SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
 	trcLoaderTask := periodic.Start(periodic.Func{
 		Task: func(ctx context.Context) {
 			res, err := trcLoader.Load(ctx)
@@ -222,6 +225,8 @@ func realMain(ctx context.Context) error {
 		}
 		cleaners := drkeyClientEngine.CreateStorageCleaners()
 		for _, cleaner := range cleaners {
+			// SA1019: fix later (https://github.com/scionproto/scion/issues/4776).
+			//nolint:staticcheck
 			cleaner_task := periodic.Start(cleaner,
 				5*time.Minute, 5*time.Minute)
 			defer cleaner_task.Stop()