refactor: scion-pki preparation for golangci-lint v2 #4771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This change is |
3 tasks
scion-pki/certs/certformat.go
Outdated
| bytes.Buffer | ||
| } | ||
|
|
||
| // Writef writes a string formated using fmt.Sprintf. |
Contributor
There was a problem hiding this comment.
The comment is outdated now
Contributor
katyatitkova
left a comment
katyatitkova
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla and @romshark)
katyatitkova
approved these changes
May 15, 2025
Contributor
katyatitkova
left a comment
katyatitkova
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla and @romshark)
romshark
commented
May 15, 2025
scion-pki/certs/certformat.go
Outdated
| bytes.Buffer | ||
| } | ||
|
|
||
| // Writef writes a string formated using fmt.Sprintf. |
katyatitkova
approved these changes
May 15, 2025
Contributor
katyatitkova
left a comment
katyatitkova
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @oncilla)
romshark
added a commit
that referenced
this pull request
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
QF1012,QF1008anderrcheckinscion-pki. This is a sub-task of #4769.