Skip to content

Conversation

@romshark
Copy link
Contributor

This is a sub-task of #4769

@romshark romshark requested a review from a team May 16, 2025 13:23
@romshark romshark self-assigned this May 16, 2025
@jiceathome
Copy link
Contributor

This change is Reviewable

@romshark romshark mentioned this pull request May 16, 2025
3 tasks
Copy link
Contributor

@katyatitkova katyatitkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @romshark)

@romshark
Copy link
Contributor Author

As explained in 2d1f66d I will close this as a won't fix.

@romshark romshark closed this May 23, 2025
romshark added a commit that referenced this pull request May 30, 2025
This finally upgrades golangci-lint to v2 including changes to the code
required by the new linter.

The most error-prone change is
2c009b0
(applying De Morgan's law in boolean expressions)

Depends on:
- [x] #4771
- [x] #4772
- [x] #4773
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants