cmd/scion-pki: improve CLI UX #4803
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
commented
Jul 9, 2025
|
|
||
| // ReadFileOrStdin reads the content of a file or stdin if the path is "-". | ||
| // It returns the content as a byte slice. | ||
| func ReadFileOrStdin(path string) ([]byte, error) { |
Contributor
Author
There was a problem hiding this comment.
Open for suggestions if there is a more suitable place to put this.
Contributor
There was a problem hiding this comment.
I believe it's fine to keep it here.
Maybe worth adding:
// ReadFileOrStdin reads the content of a file or stdin if the path is "-".
// It returns the content as a byte slice.
// Follows UNIX utility syntax guidelines.
// See https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html#tag_12_02
katyatitkova
approved these changes
Jul 9, 2025
oncilla
force-pushed
the
scion-pki-extract
branch
from
c732967 to
4c0fc53
Compare
romshark
force-pushed
the
scion-pki-extract
branch
from
4c0fc53 to
16761f5
Compare
romshark
reviewed
Dec 19, 2025
| types[typ] = true | ||
| } | ||
|
|
||
| ias := make(map[addr.IA]bool) |
Contributor
There was a problem hiding this comment.
Suggested change
| ias := make(map[addr.IA]bool) | |
| ias := make(map[addr.IA]bool, len(flags.ias)) |
romshark
reviewed
Dec 19, 2025
| Args: cobra.ExactArgs(1), | ||
| RunE: func(cmd *cobra.Command, args []string) error { | ||
| if err := runExtractCertificates(args[0], flags.out); err != nil { | ||
| types := make(map[cppki.CertType]bool) |
Contributor
There was a problem hiding this comment.
nit: sets can be used for types and ias (like map[cppki.CertType]struct{}) to reduce the ambiguity a bit.
The checks can then just be like:
if len(ias) > 0 && !ias[ia] {
continue
}
romshark
reviewed
Dec 19, 2025
| if err != nil { | ||
| return fmt.Errorf("invalid certificate %s: %w", cert.Subject.CommonName, err) | ||
| } | ||
| if len(types) > 0 && !types[typ] { |
Contributor
There was a problem hiding this comment.
if types contains typ then len(types) cannot be 0, right? Hence len(types) > 0 looks pointless to me, am I missing something?
romshark
approved these changes
Dec 19, 2025
Contributor
romshark
left a comment
romshark
left a comment
There was a problem hiding this comment.
LGTM, just some nitpicks.
I fixed the linter errors. I hope you don't mind the line breaking style.
romshark
force-pushed
the
scion-pki-extract
branch
from
ee983d1 to
c310456
Compare
The `scion-pki` CLI commands now support reading from stdin when the file path is set to `-`, where appropriate. This allows the user to pipe data directly into the command without the need to create temporary files. Furthermore, the `scion-pki trc extract certificates` command has two additional filtering options: `--type` and `--subject.isd-as`, allowing the user to filter the extracted certificates.
romshark
force-pushed
the
scion-pki-extract
branch
from
c310456 to
a469044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
scion-pkiCLI commands now support reading from stdin when the file path is set to-, where appropriate. This allows the user to pipe data directly into the command without the need to create temporary files.Furthermore, the
scion-pki trc extract certificatescommand has two additional filtering options:--typeand--subject.isd-as, allowing the user to filter the extracted certificates.