beaconing: fix diversity calculation #4854
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the beacon diversity calculation was wrong. We only considered ingress interface in construction direction. However the first ASEntry will always have a zero ingress interface. Furthermore with this approach we did not really consider the last ingress interface, which was the ingress interface into the AS, which is not yet represented by an ASEntry (as the termination/extension only happens after selection). By using the egress interfaces interfaces instead we solve both problems.
katyatitkova
approved these changes
Dec 9, 2025
FR4NK-W
reviewed
Dec 9, 2025
| beacon []uint16 | ||
| name string | ||
| beacon []uint16 | ||
| // mBeacon allows to manually specify the other beacon. |
Contributor
There was a problem hiding this comment.
nit: Maybe also mention in the comment that beacon should not be set when setting mBeacon? Or simply mention that mBeacon overrides beacon?
lukedirtwalker
added a commit
to Anapaya/os-scion
that referenced
this pull request
Dec 10, 2025
scionproto#4854 Currently the beacon diversity calculation was wrong. We only considered ingress interface in construction direction. However the first ASEntry will always have a zero ingress interface. Furthermore with this approach we did not really consider the last ingress interface, which was the ingress interface into the AS, which is not yet represented by an ASEntry (as the termination/extension only happens after selection). By using the egress interfaces interfaces instead we solve both problems.
shitz
approved these changes
Dec 10, 2025
JordiSubira
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the beacon diversity calculation was wrong. We only considered ingress interface in construction direction. However the first ASEntry will always have a zero ingress interface. Furthermore with this approach we did not really consider the last ingress interface, which was the ingress interface into the AS, which is not yet represented by an ASEntry (as the termination/extension only happens after selection).
By using the egress interfaces interfaces instead we solve both problems.