chore: upgrade to go 1.25 and modernize code base #4859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
may contain minor code formatting changes.
Since Go 1.21 min is a built-in func so it's better to rename this helper to avoid the naming conflict.
romshark
changed the title
romshark
force-pushed
the
upgrade-to-go-1-25
branch
from
46e4fa5 to
7077729
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Go 1.25.5 and overall code base modernization.
minandmaxwhere possible.reflect.TypeForwhere possible.rangeover int where possible.WaitGroup.Gomethod where possible.func min(a, b time.Time) time.TimetominTimeto avoid a naming conflict with the new built-inmin.The code changes are purely cosmetic.