Support for AND-constraints #980
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 tasks
|
Left out are |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces additional support for AND-constraints in the Python SCIP interface by adding new functions to query properties of AND-constraints and to adjust specific flags during constraint upgrades.
- New API functions to get the number of variables, the variables list, and the resultant variable from an AND-constraint.
- Added functions to sort AND-constraints and change check and removable flags during constraint upgrades.
- Updated tests and CHANGELOG to reflect the new functionality.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/test_cons.py | Added tests for the new AND-constraint functions |
| src/pyscipopt/scip.pxi | Implemented new methods for AND-constraints and flag configuration |
| src/pyscipopt/scip.pxd | Declared new C functions for AND-constraint operations |
| CHANGELOG.md | Updated changelog with support for AND-constraints |
|
@mmghannam can you give a quick glance, please? Mostly need the approval :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's missing:
SCIPchgAndConsCheckFlagWhenUpgr(),SCIPchgAndConsRemovableFlagWhenUpgr(). Not sure if it makes sense to add.As before, I haven't tried to compile, I just copied stuff.
Also moved things around a bit, I think it makes more sense to join methods by constraint handler, like in SCIP's documentation.