jquery 3.0 compatible #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlunoe
reviewed
Sep 25, 2017
| @@ -1,3 +1,4 @@ | |||
| .DS_Store | |||
| node_modules | |||
| bower_components | |||
| yarn.lock | |||
There was a problem hiding this comment.
This should probably use unix line ending (add a newline)
There was a problem hiding this comment.
Thank you so much Mlunoe: now cropit works with jquery 3
|
@scottcheng is there a reason why this is not being merged, other than my minor comment? |
|
I would love to see this PR merged and released. 👍 |
kasunshashi
approved these changes
Jun 18, 2020
mlunoe
reviewed
Oct 11, 2020
| @@ -1,3 +1,4 @@ | |||
| .DS_Store | |||
| node_modules | |||
| bower_components | |||
| yarn.lock | |||
|
@scottcheng would it be possible to get this merged soon? |
TheDoctor0
approved these changes
Oct 23, 2020
|
@scottcheng, would be great if you could merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.