Instrument aioredis #562
Open
Instrument aioredis #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This continues to suffer from the problem in #469 - instrumentation won't be preserved for async tasks triggered underneath the main one. We should solve it before merging this. |
adamchainz
force-pushed
the
issue_469_aioredis
branch
from
9a698f2 to
d1d5cf6
Compare
adamchainz
changed the base branch from
master
to
issue_557_span_context_manager
adamchainz
force-pushed
the
issue_469_aioredis
branch
from
d1d5cf6 to
943c382
Compare
tim-schilling
force-pushed
the
issue_469_aioredis
branch
from
943c382 to
2d087a7
Compare
tim-schilling
force-pushed
the
issue_469_aioredis
branch
from
c1e3e3e to
e501259
Compare
Rebuild of #552 with tracking in an aioredis-specific instrument submodule.
tim-schilling
force-pushed
the
issue_469_aioredis
branch
from
0746efb to
1823bd7
Compare
for more information, see https://pre-commit.ci
Contributor
|
There are changes occurring for pipelines in aioredis v2 which is in alpha currently. It appears that the API will be different so we may want to hold off on this until v2 is finalized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebuild of #552 with tracking in an aioredis-specific instrument submodule.