Skip to content

QtFRED Asteroid Dialog #6908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

MjnMixael
Copy link
Contributor

@MjnMixael MjnMixael commented Aug 7, 2025

Entirely rebuilds QtFRED's asteroid dialog to match the new features and fix bugs. Some notable changes here worth mentioning and I'll explain in more detail on Discord:

  • Utilize Qt's automatic slot/signal connection system in place of tons of manual connect() calls in the initializer
  • Make sure the abstract dialog's apply() returns its value instead of always returning true
  • Remove signals from the .ui file as those are a touch opaque for anyone not familiar with Qt and instead handle it with the slot/signal system
  • Rearrange how OK/Cancel, ESC, Close are intercepted to properly handle all cases especially including model validation on Apply after Reject -> Save Changes

This was also a good opportunity to add a constructor to the asteroid_field struct for easy resetting.

Fixes #1687

@MjnMixael MjnMixael added the qtfred A feature or issue related to qtFred. label Aug 7, 2025
@MjnMixael MjnMixael force-pushed the qtfred_asteroid_dialog branch from 5a23995 to f2b48e2 Compare August 7, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
qtfred A feature or issue related to qtFred.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Editor: Asteroid Field
1 participant