Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds missing entries in the garmin devices dict #13

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

adds missing entries in the garmin devices dict #13

wants to merge 9 commits into from

Conversation

socertis
Copy link

i have noticed that the garmin devices are not all listed as in the latest fit sdk, so i added them.

scrapper
scrapper reviewed Jan 19, 2019
View reviewed changes
Copy link
Owner

@scrapper scrapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove the fr920xt* entries and the fr620_taiwan entry?

scrapper
scrapper approved these changes Jan 19, 2019
View reviewed changes
Copy link
Owner

@scrapper scrapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine. Thanks for contributing!

scrapper
scrapper approved these changes Jan 19, 2019
View reviewed changes
Copy link
Owner

@scrapper scrapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are trailing whitespaces on the field 88 line. But otherwise these changes look good. Thanks for contributing!

scrapper
scrapper requested changes Jan 19, 2019
View reviewed changes
Copy link
Owner

@scrapper scrapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you want to remove this check? This should be mandatory for all FIT files. Removing this can break applications like postrunner. Please remove this from the pull request.

scrapper
scrapper requested changes Jan 19, 2019
View reviewed changes
Copy link
Owner

@scrapper scrapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should this not be mandatory? Please remove from this pull requests.

scrapper
scrapper requested changes Jan 19, 2019
View reviewed changes
Copy link
Owner

@scrapper scrapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has nothing to do with the changes to the tables. Please put this into a separate pull request.
Why should this not be a fatal problem?

scrapper
scrapper requested changes Jan 19, 2019
View reviewed changes
Copy link
Owner

@scrapper scrapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this from this pull request. Why should this not be fatal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrapper scrapper scrapper requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@socertis @scrapper