Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RSpec's described_class to make the spec a tad more idiomatic #30

Merged
merged 1 commit into from
Jul 28, 2024

Conversation

pvdb
Copy link
Contributor

@pvdb pvdb commented Jul 4, 2024

Use RSpec's described_class instead of hard-coding the name of the class-under-test, which is considered slightly more idiomatic and preferable ... also fix the name of the Ruby file in the copyright notice; thanks, @scrapper! 🙏

@scrapper scrapper merged commit 2c4af1d into scrapper:master Jul 28, 2024
4 checks passed
@pvdb pvdb deleted the geomath_spec_improvements branch July 28, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants